hip
hip copied to clipboard
lehins
Gaussian Noise Implementation
An implementation of adding Gaussian noise to images. A few changes yet to be made before producing sample outputs.
If you look at documentation of makeImageR closely you'll notice that it talks about dimensions m rows and n columns. There are place where use terms width and height, and x and y, but you use them in incorrectly. When we talk about rows we talk about height, not width, eg. when you call I.index image (x, y), you get element at x-th row (vertically, i.e. y axis) and y-th column (horizontally i.e. x-axis). This is a common mistake, since in image processing literature and software it rows and columns nomenclature is used, since that's what it usually is in matrices. For that reason I recommend to avoid using terms width and height completely, and using i and j for indexing, this prevents that common mistake from happening. Please try to go through your PRs and make the corrections. I'll try to point out in the code itself wherever I'll find.
Also, please try to make sure that the code at least compiles before submitting a PR. Just run stack test.
@lehins Sorry sir but actually, I had a query in a part or two and hence left a couple things deliberately. I had a doubt whether this was the correct way. Secondly, I was not sure what list/array to use for the purpose. As in lines 87-90, I'm unsure how to convert and use the generated values from normals' .