Kunal Mehta
Kunal Mehta
I have a preference to any library that is already relatively well maintained in Debian :) Both libcurl and libmicrohttpd are popular and used by other projects and have good...
This is the remaining issue preventing reproducibility of `securedrop-app-code`. The issue is really subtle, the only thing that varies is the "build ID". pip ends up building each wheel in...
Also, during package builds we're currently building all of the Python dependencies *twice*. Using pre-built wheels will cut that down to zero times.
I filed #6546 to clean up how our requirements.txt files are organized before we embark down this.
Current work in flight: * https://github.com/freedomofpress/securedrop-debian-packaging/pull/382 - makes room to add sever wheels into the repo, reusing the same bootstrapping scripts * https://github.com/freedomofpress/securedrop-debian-packaging/pull/383 is a draft of adding the server...
Nope, go for it! Let me know if you have any questions.
My specific proposal is `bootstrap-requirements.in`: ``` pip>=21.3 setuptools>=56.0.0 setuptools-scm>=6.0.1 wheel ``` And then `translation-requirements.in`: ``` babel>=2.9.1 sh ``` (sh might go away in https://github.com/freedomofpress/securedrop/issues/6547). Waiting on #6544 because it'll probably...
Here's my demo of this change against securedrop-client: https://github.com/freedomofpress/securedrop-debian-packaging/commit/a580cf01d5f634b80f98c64230f4398da0603bd0 - I think it's significantly clearer exactly what is happening during the install step (the sed step probably needs a comment)....
I tagged this with needs discussion because my personal opinion is that the checks were not useful and if we just dropped them that would be fine. I think other...
> [#6537 (comment)](https://github.com/freedomofpress/securedrop/pull/6537#issuecomment-1239541960) is an example of an LGTM report which I think is somewhat useful. All of those are already pylint checks: * Unused import: https://pylint.pycqa.org/en/latest/user_guide/messages/warning/unused-import.html * Non-callable called:...