Kunal Mehta

Results 276 comments of Kunal Mehta

I just rebased and squashed all the commits prior to the SDK/client test work and attempted to write longer commit message for the resulting commits and in a few cases...

client functional tests are failing because AFAICT those are still using the old VCR format. Will look at converting those tomorrow. We also need to add a Rust compiler to...

I've basically gotten the infrastructure for using the custom VCRAPI and Cassettes in the functional tests, but I'm debugging an issue in which the cassette seems to be re-recording its...

CI is now passing except the cargo vet (because we still need to vet the dependencies) \o/ I've also squashed it down to 11 commits. Remaining steps: * [ ]...

Thanks, I approved all of your documentation improvements (might amend to break long lines if needed) - will review the rest shortly.

For some reason the existing cassettes are no longer sufficient and therefore it's trying to invoke the proxy, but CI intentionally doesn't have a Rust toolchain, so it fails. So...

> @legoktm, I haven't bisected to confirm this hypothesis, but it occurs to me that [c6a13d0](https://github.com/freedomofpress/securedrop-client/commit/c6a13d0ee428aa489ab14ca62a04a4233f9d5c33) changes the version of `werkzeug`, which appears in (e.g.): I don't think it's that...

I bisected to 18e19c3b and the solution is a bit embarrassing: `~/Downloads` doesn't exist in the CI container. Now, `~/QubesIncoming` didn't either, but we weren't actually checking that one existed....

Rebased with minimal squashing, CI is passing now, so what's left is: * visual review from 3rd person * verification testing in Qubes dev env (now that apparmor/Downloads are fixed)

> [ ] Build and install debs onto Qubes 4.2 system, test syncing, sending replies and downloading attachments works fine I've verified this was working and ticked it off. @micahflee...