Kunal Mehta

Results 276 comments of Kunal Mehta

Good spot @cfm, we only attempt public key migration during the alembic upgrade and never again. This should not be a functional issue for sources, because everything will continue to...

Prior to the Sequoia work, sources were conceptually in 3 states: A) created, no gpg key pair B) gpg key pair created C) deleted. In that sense the data is...

Unfortunately we still need to be compatible with GPG for decryption on the journalist side, so this will have to wait until https://github.com/freedomofpress/securedrop-workstation/issues/812 happens.

It might make sense to jump to Flask 2.2.0 as an interim step, since that seems to introduce a lot of new functionality (JSON provider, some config attributes) where the...

Hi @TkTech! Thanks for your work on Flask-Babel and for being proactive in finding this issue :) I already made a few changes along those lines (see https://github.com/freedomofpress/securedrop/commit/08d6704bc592d12c1d7306c2fd4f9e6dcf6d3796) but here's...

> so do `with app.app_context()` before your call, since you have a valid app object at this point. Oh, duh. This worked perfectly, thanks :)

With the release of 2.7.0, this is now done :)

We've now done 2 updates through this system, which went pretty well IMO. I filed tasks for the two issues that didn't have them yet, so I think we can...

I tried out `cargo vet` today, it seems to work pretty nicely. The main "issue" I ran into was that we are deploying to a very specific platform ("target" in...

Thinking closely about the Python diff review workflow, there are two steps missing: * We don't verify that the version we review matches checksum of what is included in Cargo.lock....