stanza icon indicating copy to clipboard operation
stanza copied to clipboard

ref(muc): rejoin MUC with initial presence

Open paweldomas opened this issue 5 years ago • 6 comments

Stanza will rejoin rooms after auto reconnect, but it forgets what presence was used. This commit introduces RoomState where the initial presence is stored.

paweldomas avatar Nov 13 '20 19:11 paweldomas

ah this breaks the tests, I need to take a look

paweldomas avatar Nov 13 '20 19:11 paweldomas

@paweldomas any progress on this?

Sheharyar566 avatar Apr 23 '21 06:04 Sheharyar566

@Sheharyar566 I'm running from a fork, I don't know if this change will land upstream

paweldomas avatar Apr 23 '21 15:04 paweldomas

Btw. this PR still has a problem where if you have sent any other presence since the initial join it will not be used, but reverted back. Maybe it's better to leave it up to the app to send presence on rejoin. Otherwise any presence update sent to the room needs to be cached and I'm not sure what's the best way of doing it in Stanza.

paweldomas avatar Apr 23 '21 15:04 paweldomas

@paweldomas ah makes sense.... thanks for the update man

Sheharyar566 avatar Apr 24 '21 06:04 Sheharyar566

sorry @paweldomas for i'm borrowing this thread ;)... yo @legastero can you please enable the issues section again (not sure why you hid it in the first place without notifying or may be I missed the notification sorry for that tho)? Or may be put something in the readme please, regarding how to connect to the discuss server? cause i'm getting Access Denied by Server Policy on connecting to the server.

Sheharyar566 avatar Apr 29 '21 10:04 Sheharyar566