Manuel Pirker-Ihl

Results 15 comments of Manuel Pirker-Ihl

The same issue also seems to occur for renaming btw

Will this also cover the issue for renaming assets?

As mentioned in #80 - the writeMeta data will be called 3 times. only at the first time it has the metadata

@ryanmitchell If this line: https://github.com/statamic/eloquent-driver/blob/de33af216ca369a3c4ccb07aa97fa176b7b97dc9/src/Assets/Asset.php#L63 is not set meta data won't be overwritten. But i think we could change the code to: ```php $handle = $this->container()->handle().'::'.$this->metaPath(); if ($model = app('statamic.eloquent.assets.model')::where('handle',...

> Hmm that feels like an unnecessary db query - keen to avoid that. Does[ this change help](https://github.com/statamic/eloquent-driver/pull/71/commits/e7690c8f76cf8dc6843f8a43fb27322f3cf40714)? I am afraid it doesn't solve the issue right now. :/

@ryanmitchell do we really need "$this->writeMeta($meta = $this->generateMeta());" in metaValue? I just removed it from the method (your latest version) and moving/renameing worked without losing meta data. eg: ```php private...

I am going to prepare one :)

Are there any plans to integrate that PR into master? It would be pretty nice, cause i have laravel 8 project which would benefit from that :-)

Do you have a repo where i can reproduce that issue? :)

is there no manifest.json in your dev console or what exactly is the issue?