serverless-api-stage icon indicating copy to clipboard operation
serverless-api-stage copied to clipboard

Modify CF template before nested stacks get created

Open rmbl opened this issue 5 years ago • 2 comments

We're using serverless-plugin-split-stacks to split the resulting CF template into nested stacks. This occurs on after:aws:package:finalize:mergeCustomProviderResources which is part of package:finalize. Because of this the Stage gets added too late and leads to errors when deploying it to AWS.

This PR moves the modifications from this plugin to the beginning of package:finalize to fix that.

rmbl avatar Mar 28 '19 14:03 rmbl

Is there anything blocking this from being merged and released?

juanjoDiaz avatar Oct 08 '20 14:10 juanjoDiaz

I should probably fix the tests. Other than that it has been working since then over a few hundred deployments for us.

rmbl avatar Oct 08 '20 14:10 rmbl