Tobias Roeser

Results 847 comments of Tobias Roeser

> This is the only ticket directly addressing mill’s bom support, so, I hope my comment is not out of place. After reading [the docs](https://mill-build.org/mill/fundamentals/library-deps.html#_managed_bill_of_material_bom), it’s unclear why one may...

I'm pretty sure docs can always improved. Should we motivate it? I'm not so sure. We now have it in Mill for those users who need it, but I'm not...

> I'm thinking of a case where we depend on version `1.2.0` of a dependency, and another dependency pulls version `1.2.5` of it. If we use a BOM for `1.2.0`,...

The `import`-scope Maven dependencies are called BOM - Bill of Material. There are open requests for it in Mill and coursier: * https://github.com/com-lihaoyi/mill/issues/1975 * https://github.com/coursier/coursier/issues/1390 I think @alexarchambault will work...

The proper way to refer to already existing modules is to use `ModuleRef`. ```scala import mill._, scalalib._ trait CommonModule extends ScalaModule { def scalaVersion = "2.13.12" def m1 = ModuleRef(mym1)...

@myyk This is exactly the point where I stopped to investigate. Since this is reflection land, we can't know for sure whether the instance is meant to be a singleton....

We could try to look for patterns though. E.g. whenever we instantiate a module, we could look into the chain of parents. E.g. if we find the same types in...

We do have `object`s in `trait` sometimes, which are valid child modules. So we need to be careful with errorring out just on heuristics. I know we had it in...

> > We do have objects in trait sometimes, which are valid child modules. So we need to be careful with errorring out just on heuristics. I know we had...

This is also an opportunity, to have each BSP extension in it's own namespace (Java package), e.g. `ch.epfl.scala.bsp4j.protocol.{base,jvm,java,scala,sbt,rust,...}`.