Tobias Roeser

Results 290 comments of Tobias Roeser

While the above examples would allow slick single module projects, we could also go the other way, by not wrapping at all. ```scala //> using mill.entry `TopModule` trait TopModule extends...

> This is a breaking change that won't easily allow for users to use 1.x anymore. Are you ok with that? Once scoverage bumps to 2.x it will be pretty...

@ckipp01 Let me know if you need further guidance in creating a new worker module for Scoverage 2.x. Or just ping me in our Gitter channel.

Is anybody working on this? @ckipp01 or @kierendavies ?

As there is nobody currently working on this and we decided to keep the old worker but also as there are merge conflicts in this PR, I decided to re-start...

My suspicion is, that this is true for all evaluator command.

This looks ok so far, but this need to wait until the next major version (probably `0.11`), as it changes the dependencies between targets which is an issue for downstream...

> This looks ok so far, but this need to wait until the next major version (probably `0.11`), as it changes the dependencies between targets which is an issue for...

This is the error in CI: ``` X mill.scalalib.bsp.BspModuleTests.bspCompileClasspath.single module.dependent module 362ms utest.AssertionError: #2: relResults == expected, relResults: Seq[os.FilePath] = Vector(/home/runner/work/mill/mill/target/worksources/mill/scalalib/bsp/BspModuleTests/MultiBase/HelloBsp/compile-resources, /home/runner/work/mill/mill/target/worksources/mill/scalalib/bsp/BspModuleTests/MultiBase/HelloBsp2/resources, /home/runner/work/mill/mill/target/workspace/mill/scalalib/bsp/BspModuleTests/eval/bspCompileClasspath/single module/dependent module/HelloBsp/compile.dest/classes, logback-classic-1.1.10.jar, logback-core-1.1.10.jar, scala-library-2.13.8.jar, slf4j-api-1.7.34.jar) expected:...

As you touch `scalalib` it's a good idea to run `scalalib.test`, at least. It's perfectly ok to push and just review what the CI reports. Besides of some sporadic CI...