OpenBVE icon indicating copy to clipboard operation
OpenBVE copied to clipboard

RW format conversion expects explicit speed parameter in Track.Announce

Open alex-wenzel opened this issue 3 months ago • 2 comments

An RW format command such as @announce(\NYCT-V\BwayLafAnn.wav) will raise "Invalid closing parenthesis encountered at line ...". Changing it to @announce(\NYCT-V\BwayLafAnn.wav, 0) resolves the error. Since the CSV documentation says that Track.Announce(FileName; Speed) gives Speed a default value of 0 and the RW quick reference doesn't mention Track.Announce() in its list of behavior difference, I assume that many legacy RW routes will omit explicit values for Speed.

I haven't had a chance yet to sit down and walk my way through the conversion logic, but I'm guessing that this bug comes from some combination of current line 166 and current line 210 in CsvRwRouteParser.Expression.SeparateCommandsAndArguments.

alex-wenzel avatar Oct 27 '24 19:10 alex-wenzel