Wrap 'callfopen' function with 'TINYXML2_FILE_SUPPORT' to ensure consistency

Open AlbertHungGarmin opened this issue 1 year ago • 2 comments

The 'callfopen' function, used for opening files, is now wrapped with the 'TINYXML2_FILE_SUPPORT' preprocessor directive. This change aligns with the usage in 'LoadFile' and 'SaveFile' functions, which are also wrapped with 'TINYXML2_FILE_SUPPORT'. This ensures that the function is only compiled and used when file support is enabled, providing consistency across the codebase.

Mar 13 '24 06:03 AlbertHungGarmin

Change-Id: I406c09db435d50f27daa244e39941d07c0fd3d4a

Change-Id is a gerrit feature, and should not be included in a github pull request.

Mar 19 '24 02:03 admorgan

@admorgan , Thanks for your comment.

Mar 19 '24 03:03 AlbertHungGarmin

TINYXML2_FILE_SUPPORT isn't defined anywhere - how can this work?

Apr 21 '24 02:04 leethomason

The TINYXML2_FILE_SUPPORT configuration exists in my local repository. Sorry that it doesn't exist in upstream.

May 13 '24 06:05 AlbertHungGarmin

It doesn't make sense to integrate something that isn't in this repo.

Jun 13 '24 15:06 leethomason