tinyxml2 icon indicating copy to clipboard operation
tinyxml2 copied to clipboard

Increase depth recursion limit

Open quagla opened this issue 2 years ago • 2 comments

The depth recursion limit TINYXML2_MAX_ELEMENT_DEPTH = 100 is quite restrictive for some applications. We encountered it here, where it is limiting our users from forming simulated chains with more than 100 joints (here is a video of a simulated chain, for illustration). While we of course accept that some limit is required for safety, we feel that 100 is too small.

This PR proposes to increase it to 500, which matches the depth allowed by other standard parsers, see e.g. libxml2 and IBM DataPower.

Thanks for your time and consideration.

quagla avatar Jun 07 '22 05:06 quagla

Any updates on this?

tudorjnu avatar Aug 07 '22 12:08 tudorjnu

Max element nesting depth 100 feels way too small to me, too. Please see also this thread

traplotz avatar Aug 18 '22 10:08 traplotz

@leethomason Is there any update on this pull request?

quagla avatar Nov 28 '22 11:11 quagla

@leethomason Is there any update on this? Thank you!

tudorjnu avatar Jan 02 '23 13:01 tudorjnu

There is no value for that to make everyone happy. :) But I'm good with trying 500.

leethomason avatar Jan 15 '23 01:01 leethomason

That is more than enough! Thank you very much @leethomason ! 😁

tudorjnu avatar Jan 16 '23 10:01 tudorjnu