leethomason
code layout
This is an issue about readability of the code, not about a bug in the code.
I don't like to make any changes in your code, not even changing layout. If I do make changes it will immediately any future compare for changes.
Some people like to use tabs for indenting, some set it to 4 spaces, others to 8 and again there are peope using 2 spaces for an indent. What I meen to say, when using tabs for your layout it is fine for you but for many other it is not. (Well, with the exception for Python code, but that is an other case all together).
Would you please consider changing your layout to spaces. If you use 8 spaces for a tab everybody will get 8 spaces in the layout. And if you user for, again everybody gets readable code layout.
I make this request because I noticed that my use of tabs is different than that of yours and it makes your code layout a bit unpleasant to read for me.
Kind regards,
I'd like to update the formatting:
- switch to the Visual Studio style, which seems reasonably standard (and close to the Artistic Style defaults)
- switch to tabs being written as 4 spaces
It causes a HUGE discontinuity in source, since it essentially changes every line of code. I'd be interested to see if there is a general sense it is worth doing.
Technically it isn't even an update. Just causes a discontinuity in the source. Many people diff updates, so I wouldn't wrap it into that.
If you want to do it and want to somehow minimise the impact on a diff then doing it with a major update sounds sensible to me. Most people who do a diff on an update expect minor changes on a minor version bump. Diffing between major vesion bumps is less likely (I think). I can't come up with a better moment to do it.