tinyxml2 icon indicating copy to clipboard operation
tinyxml2 copied to clipboard

Why are so many `class XMLUtil` members inline?

Open Dmitry-Me opened this issue 10 years ago • 1 comments

I see that even StringEqual() is declared inline. Is that necessary? What would happen if it was inside the .cpp?

Dmitry-Me avatar Jul 30 '15 14:07 Dmitry-Me

There was some intent for performance, but it went too far. And clutters the headers. I'd support moving the larger ones (StringEqual) inline, but leave the small ones (IsUTF8Continuation.)

leethomason avatar Aug 07 '15 22:08 leethomason