Lee Thomason
Lee Thomason
I'll second this issue. I've seen the problem when I pass a char* to MurmerHash3. In this line: ` const uint64_t * blocks = (const uint64_t *)(data);` in `https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp` The...
I added comments to an existing issue: https://github.com/aappleby/smhasher/issues/74
Do you mind patching up the other unaligned reads in string_pool.cpp? Then everything would be tidy and consistent.
Good point; we'll hold off on this and look again after FAH.
A wash to the FAH work.
The memory optimization work of this PR was consumed by the fatal attribute hash refactoring. We are moving ORC in the direction of static immutable memory, which is certainly the...
Yeah, I'm no super happy with the VS files myself. Generally speaking, I'd like to 1) move the VS project to 2017 (I know this is counter to your needs,...
Actually, you first impression was correct. The New\* makes the node owned by the Document. If you delete the Document, the memory will get cleaned up. The memory is stored...
Adding "bug" status.