Lee Prevost

Results 70 comments of Lee Prevost

> In your test case, and what I missed in your original post, I see you're trying to JSON serialize a _private_ property, `extractor._get_tld_extractor().tlds_incl_private_trie`. I don't necessarily want to make...

> @leeprevost again thanks for your detailed breakdown in your branch. An update this morning. It was bothering me that we didn't get speed gains. So, I tried to implement...

> Is pickling still an option? You say you're encountering errors with this library and `pickle`. Yet the following tests pass for me in 5.1.3. Odd. I had convinced myself...

Now wondering if I tried to pickle the private extractor? If your test above works (pre and post lazy) on current rev, am now wondering if a pure python dict...

> Googling your pickle error, [this SO may be a guiding set of links](https://datascience.stackexchange.com/questions/74172/picklingerror-in-pyspark-picklingerror-cant-pickle-class-main-person). This sentence in particular applies to the current release Trie: ``` So, instances of classes that...

Ok, I'll try to circle back to reproduce that error. No problem on not pursuing it. I would do the same if I were you. As to a public interface,...

> For the third group, you're right, `extra_suffixes` would let you treat https://weebly.com the same way the PSL treats e.g. https://blogspot.com. @john-kurkowski, I'm circling to creating a custom extra_suffixes list...

> > I want to add them back to the suffix list > > [@leeprevost](https://github.com/leeprevost) let me know if I'm misunderstanding, but I think you're looking to _subtract_ certain suffixes...

OK, thank you. I can work around this now that I know what the rules are. Could you point me to source so that I can see the ruleset? And...

OK - I thought I saw a definitions page with the regex sequences it was using to parse. But, if not easy, I'll work around this. Want me to close...