passport-token icon indicating copy to clipboard operation
passport-token copied to clipboard

Should not call to lowercase on your custom authentication keys

Open ekryski opened this issue 9 years ago • 1 comments

First off. Thanks for writing the module! Much appreciated.

I'm going to issue a PR to remove the call of toLowerCase() on these lines. This actually bit me and I spent quite a bit of time trying to figure out what went wrong. I don't think it should be the responsibility of passport-token to make the strings lowercase. I think that concern should be left up to the person implementing.

ekryski avatar Mar 25 '15 20:03 ekryski

Hi. Sorry, this module was written really very quickly for a personal project (that never even made it to production). After that I kind of forgot about it - and never really thought anyone would use it!

I'll try to do a review in the next couple of days and get your changes in.

leepowelldev avatar Mar 26 '15 11:03 leepowelldev