designcourse icon indicating copy to clipboard operation
designcourse copied to clipboard

use baggage for user.id / account.id forwarding

Open cgcote opened this issue 7 months ago • 3 comments
trafficstars

Motivation

Switch usr.id / account.id context forwarding to baggage instead of tracestate.

Changes

Adds a flag propagateTraceBaggage to activate the baggage forwarding.

Testing

  • [x] Local
  • [ ] Staging
  • [x] Unit
  • [ ] End to end

I have gone over the contributing documentation.

cgcote avatar Mar 26 '25 08:03 cgcote

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Mar 26 '25 08:03 bits-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.93%. Comparing base (22cbbf4) to head (d05757e). Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3445      +/-   ##
==========================================
+ Coverage   91.92%   91.93%   +0.01%     
==========================================
  Files         309      309              
  Lines        8109     8112       +3     
  Branches     1838     1841       +3     
==========================================
+ Hits         7454     7458       +4     
+ Misses        655      654       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Mar 26 '25 08:03 codecov-commenter

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 146.98 KiB 146.88 KiB -99 B -0.07%
Logs 51.38 KiB 51.38 KiB 0 B 0.00%
Rum Slim 106.21 KiB 106.11 KiB -99 B -0.09%
Worker 23.59 KiB 23.59 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.037 0.042 0.005
addtiming 0.001 0.001 0.000
adderror 0.040 0.043 0.003
startstopsessionreplayrecording 0.007 0.014 0.006
startview 0.389 0.422 0.034
logmessage 0.020 0.021 0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 28.40 KiB 27.68 KiB -740 B
addaction 55.91 KiB 54.93 KiB -1009 B
addtiming 25.95 KiB 25.65 KiB -310 B
adderror 56.93 KiB 61.59 KiB 4.65 KiB
startstopsessionreplayrecording 26.29 KiB 24.59 KiB -1749 B
startview 421.53 KiB 433.81 KiB 12.28 KiB
logmessage 56.06 KiB 60.38 KiB 4.32 KiB

🔗 RealWorld

cit-pr-commenter[bot] avatar Mar 26 '25 08:03 cit-pr-commenter[bot]

/to-staging

cy-moi avatar Apr 04 '25 09:04 cy-moi

View all feedbacks in Devflow UI.

2025-04-04 09:54:51 UTC :information_source: Start processing command /to-staging


2025-04-04 09:54:56 UTC :information_source: Branch Integration: starting soon, merge expected in approximately 15m44s (p90)

Commit a49c1b018e will soon be integrated into staging-14.


2025-04-04 09:59:36 UTC :rotating_light: Branch Integration: The build pipeline contains failing jobs for this merge request

We couldn't automatically merge the commit a49c1b018e into staging-14. Build pipeline has failing jobs for af06139:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

If you think the errors come from a logical conflict with the target branch, you can create a fix by commenting this pull request with /create-fix-branch -b staging-14

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

dd-devflow[bot] avatar Apr 04 '25 09:04 dd-devflow[bot]

/create-fix-branch -b staging-14

cy-moi avatar Apr 04 '25 11:04 cy-moi

View all feedbacks in Devflow UI.

2025-04-04 11:33:37 UTC :information_source: Start processing command /create-fix-branch -b staging-14


2025-04-04 11:33:44 UTC :information_source: Devflow: /create-fix-branch -b staging-14

Created fix branch fix-merge-a49c1b018e-into-staging-14 - #3467

dd-devflow[bot] avatar Apr 04 '25 11:04 dd-devflow[bot]

:steam_locomotive: Branch Integration: starting soon, merge expected in approximately 15m44s (p90)

Commit a49c1b018e will soon be integrated into staging-14.

dd-devflow[bot] avatar Apr 04 '25 11:04 dd-devflow[bot]

:steam_locomotive: Branch Integration

Commit a49c1b018e has been merged into staging-14 in merge commit e8c3d1ddc3.

Check out the triggered pipeline on Gitlab :fox_face:

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-14

dd-devflow[bot] avatar Apr 04 '25 12:04 dd-devflow[bot]