designcourse icon indicating copy to clipboard operation
designcourse copied to clipboard

Published 20 hours ago • verified publisher icon leeper

✨ Allow to pass custom tags

Open maksimaderikha opened this issue 2 years ago • 2 comments
trafficstars

Motivation

The goal of this PR is to allow users to pass any custom tags along with the built-in ones. See the issue https://github.com/DataDog/browser-sdk/issues/462 for more details.

Changes

This PR adds optional customTags property to the configuration object, so that logger or rum may be configured to send additional tags. This is completely optional configuration option that will not impact existing configurations. The changes also do not allow overwriting the built-in tags.

Testing

  • [x] Local
  • [ ] Staging
  • [x] Unit
  • [ ] End to end

I have gone over the contributing documentation.

maksimaderikha avatar Jun 27 '23 15:06 maksimaderikha

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Jun 27 '23 15:06 bits-bot

Hello @maksimaderikha, Thanks for the PR. Link mentioned in https://github.com/DataDog/browser-sdk/issues/462, we are still thinking about merging the attributes and tags concepts in the future so we are not willing to introduce this kind of API for now. What about using a global context attribute instead of a tag?

amortemousque avatar Jul 04 '23 14:07 amortemousque