umbraco-contentment icon indicating copy to clipboard operation
umbraco-contentment copied to clipboard

Content Blocks: Validation error doesn't clear when corrected on child item

Open CarlSargunar opened this issue 1 year ago • 4 comments

Which Contentment version are you using?

4.4.2

Which Umbraco version are you using? For example: 8.14.1 - don't just write v8

10.4.2

Bug summary

With nested element types in Data Blocks, validation errors aren't cleared on Publish, but ARE cleared on save.

I've recorded a screencap of me reproducing this error - zipped up as it's too big otherwise

2023-04-12 22-44-24.zip

Steps to reproduce

Set up a data list using contentblocks, with a required field on one of the element types.

  • Try and publish without a required field populated (this works as expected)
  • Update the field to clear the validation error
  • Try and publish - this fails
  • Saving will work, and after saving I can then publish

Expected result / actual result

No response

Do you have Umbraco ModelsBuilder enabled?

  • [X] Yes, it is enabled.

What browsers are you seeing the problem on?

No response

CarlSargunar avatar Apr 12 '23 21:04 CarlSargunar

Happy to help try and fix this - but I'd need some pointers to know where to start looking (angularJS is not my strongest)

CarlSargunar avatar Apr 12 '23 21:04 CarlSargunar

Thanks for raising this @CarlSargunar.

This could be with the server-side validation for Content Blocks that I'd added in v4.4.2, commit: 7706d882f189e520003db8c80bfceb1191bf91c9 I'd tried to follow the same pattern as Umbraco's BlockList and NestedContent, so I'm unsure why it wouldn't re-validate on Publish, but it does for Save. 🤔 (I'll give it some thought.)

leekelleher avatar Apr 15 '23 14:04 leekelleher

Hi @leekelleher @CarlSargunar

I am facing the same issue in contentment v4.4.5. Just checking if this has been resolved?

Deba22 avatar Mar 18 '24 09:03 Deba22

@Deba22 Unfortunately it hasn't been resolved. I was able to reproduce the issue, but unable to figure out how to fix it. It's open for community help if anyone else knows how to fix it.

leekelleher avatar Mar 18 '24 09:03 leekelleher