reflex icon indicating copy to clipboard operation
reflex copied to clipboard

Slash for divisions in SCSS will be deprecated

Open jeroen-slagt opened this issue 3 years ago • 1 comments

Hi,

reflex-grid/scss/includes/_mixins.scss
uses a slash for division calculations. percentage(($index / $reflex-columns))

This will be deprecated in SCSS in the future Please use: math.div($index, $reflex-columns)

See: https://sass-lang.com/documentation/breaking-changes/slash-div

jeroen-slagt avatar Jun 14 '21 13:06 jeroen-slagt

calc($index / $reflex-columns) will also work, which makes it perhaps a bit more readable code.

questionmark78 avatar Jul 25 '22 08:07 questionmark78

@leejordan If I submit a pull request to fix this, would it be accepted?

chrisrosner avatar Aug 18 '23 05:08 chrisrosner

Yes for sure. I don't write code much these days but I would make a new release of this.

On Fri, 18 Aug 2023, 06:34 Chris Rosner, @.***> wrote:

@leejordan https://github.com/leejordan If I submit a pull request to fix this, would it be accepted?

— Reply to this email directly, view it on GitHub https://github.com/leejordan/reflex/issues/68#issuecomment-1683376773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFOETIYLF3YXHOHW2XOVHLXV35HVANCNFSM46VGXBWQ . You are receiving this because you were mentioned.Message ID: @.***>

leejordan avatar Aug 18 '23 07:08 leejordan