reflex
reflex copied to clipboard
Slash for divisions in SCSS will be deprecated
Hi,
reflex-grid/scss/includes/_mixins.scss
uses a slash for division calculations.
percentage(($index / $reflex-columns))
This will be deprecated in SCSS in the future Please use: math.div($index, $reflex-columns)
See: https://sass-lang.com/documentation/breaking-changes/slash-div
calc($index / $reflex-columns) will also work, which makes it perhaps a bit more readable code.
@leejordan If I submit a pull request to fix this, would it be accepted?
Yes for sure. I don't write code much these days but I would make a new release of this.
On Fri, 18 Aug 2023, 06:34 Chris Rosner, @.***> wrote:
@leejordan https://github.com/leejordan If I submit a pull request to fix this, would it be accepted?
— Reply to this email directly, view it on GitHub https://github.com/leejordan/reflex/issues/68#issuecomment-1683376773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFOETIYLF3YXHOHW2XOVHLXV35HVANCNFSM46VGXBWQ . You are receiving this because you were mentioned.Message ID: @.***>