react-native-swiper icon indicating copy to clipboard operation
react-native-swiper copied to clipboard

Published 20 hours ago • verified publisher icon leecade

Fix content offset value

Open kyle-ssg opened this issue 5 years ago • 5 comments

Is it a bugfix ?

  • Yes
  • https://github.com/leecade/react-native-swiper/issues/1053

Describe what you've done:

The contentOffset was looking inside state rather than this.internals, where the offset is adjusted. This means as soon as setState is called the offset resets.

How to test it ?

Create a swiper with 2 slides, swipe to slide 2 and then trigger a setState.

kyle-ssg avatar Oct 26 '19 12:10 kyle-ssg

Can we please merge this? This PR has been out for a long time and fixes a breaking bug on iOS devices.

0kzh avatar Jun 11 '20 16:06 0kzh

Hate to admit it but unless this repo gets transferred to react-native-community I'd consider it dead.

kyle-ssg avatar Jun 12 '20 09:06 kyle-ssg

very good

xiaowu2333 avatar Nov 17 '20 02:11 xiaowu2333

Thank you

HeidiAshraf avatar Nov 17 '20 11:11 HeidiAshraf

Thank you

marlti7 avatar Mar 08 '22 02:03 marlti7