rollup-plugin-flow icon indicating copy to clipboard operation
rollup-plugin-flow copied to clipboard

Published 20 hours ago • verified publisher icon leebyron

[breaking] bump required node version to 10+, update underlying lib

Open quantizor opened this issue 5 years ago • 3 comments

This PR composes #10 and adds the bits to upgrade the library for Node 10+

Note that I pinned flow-remove-types intentionally to the slightly lower version because the newer one is buggy as @unscriptable mentioned in their original PR.

quantizor avatar Sep 01 '20 00:09 quantizor

This looks great to my eyes, @probablyup. Is it customary to commit yarn.lock in library repos?

unscriptable avatar Sep 09 '20 23:09 unscriptable

Usually yeah, so you get consistent builds.

Sent from my iPhone

On Sep 9, 2020, at 7:44 PM, John Hann [email protected] wrote:

 This looks great to my eyes, @probablyup. Is it customary to commit yarn.lock in library repos?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

quantizor avatar Sep 10 '20 00:09 quantizor

@leebyron ping

quantizor avatar Sep 21 '20 20:09 quantizor