Lee Byron

Results 123 comments of Lee Byron

I noticed that in your example, `Connection` is not being used anywhere, and removing it should result in a valid schema: ``` type Query { test: MyConnection } interface Node...

Another suggestion would be to move the union to the connection types instead of the node types: ``` union MyConnection = | ConnectionA | ConnectionB type ConnectionA implements Connection {...

Great - I'd suggest taking a look at https://github.com/facebook/graphql/blob/master/CONTRIBUTING.md#contributing-to-graphql-libraries which is hopefully helpful in guiding you towards next steps if you'd like to champion this effort

Sorry for missing the previous comment. I believe this is just waiting for a proposal from a champion. The document I linked in a prior comment should help guide you...

I made some fairly significant edits to the prose and examples section in an attempt to simplify. @magicmark please take a look and let me know what you think.

IIRC the only thing holding this from Approval stage is a landed GraphQL.js PR?

I think this is good to go again. I've just added the GraphQL.js implementation which greatly helped in completeness checking this spec change

Looks like the negative lookahead for `.` isn't rendering exactly right. I'll need to do a fix on spec-md before merging

It’s meant to only apply to the dot

I think I was trying to over-simplify by keeping this all in the `one of` and that's falling short on clarity. Here's an interesting existing case I'll try to model...