lua-resty-http icon indicating copy to clipboard operation
lua-resty-http copied to clipboard

fix poolname to include the digest of the cert for mTLS

Open catbro666 opened this issue 1 year ago • 8 comments

Fix https://github.com/ledgetech/lua-resty-http/issues/306

Additionally, add the latest openresty versions in CI. OpenResty has already supported tcpsock:setclientcert from 1.21.4.2 so only skip the mtls tests when version < 1.21.4

catbro666 avatar Jan 10 '24 03:01 catbro666

Hi @pintsized could you review and merge this when you have time?

catbro666 avatar Jan 15 '24 07:01 catbro666

ping this

catbro666 avatar Jan 23 '24 02:01 catbro666

ping @pintsized This one has been open for a long time. Could you have a look?

catbro666 avatar Feb 23 '24 03:02 catbro666

ping @pintsized This one has been open for a long time. Could you have a look?

Sorry, I have no time to look at this at the moment. I'd appreciate some more eyes on it if anyone has time, perhaps some Kong folk? @Tieske @chronolaw

pintsized avatar Feb 26 '24 11:02 pintsized

@chronolaw can you have another look. lgtm now.

Tieske avatar Feb 27 '24 20:02 Tieske

I notice that there is some code (https://github.com/ledgetech/lua-resty-http/pull/307/files#diff-a717dcbee90c573feec0be98675c64ff06bf5bb3d8bb3d30b66b131952e22a3cR169), it return three values, but the client only uses two (ok, err), is it a bug? should we fix it?

chronolaw avatar Feb 28 '24 03:02 chronolaw

I notice that there is some code (https://github.com/ledgetech/lua-resty-http/pull/307/files#diff-a717dcbee90c573feec0be98675c64ff06bf5bb3d8bb3d30b66b131952e22a3cR169), it return three values, but the client only uses two (ok, err), is it a bug? should we fix it?

Yeah, I think so. Fixed them.

catbro666 avatar Feb 28 '24 03:02 catbro666

@pintsized I think this is good to go now.

Tieske avatar Feb 28 '24 09:02 Tieske

Great work everyone, thank you!

pintsized avatar Feb 29 '24 13:02 pintsized

@pintsized Could you bump a new version? Appreciate it.

catbro666 avatar Feb 29 '24 13:02 catbro666

@pintsized Could you bump a new version? Appreciate it.

0.17.2 is now on luarocks. I'm having some issues with opm, but it will be there once resolved.

pintsized avatar Feb 29 '24 20:02 pintsized