fix poolname to include the digest of the cert for mTLS
Fix https://github.com/ledgetech/lua-resty-http/issues/306
Additionally, add the latest openresty versions in CI. OpenResty has already supported tcpsock:setclientcert from 1.21.4.2 so only skip the mtls tests when version < 1.21.4
Hi @pintsized could you review and merge this when you have time?
ping this
ping @pintsized This one has been open for a long time. Could you have a look?
ping @pintsized This one has been open for a long time. Could you have a look?
Sorry, I have no time to look at this at the moment. I'd appreciate some more eyes on it if anyone has time, perhaps some Kong folk? @Tieske @chronolaw
@chronolaw can you have another look. lgtm now.
I notice that there is some code (https://github.com/ledgetech/lua-resty-http/pull/307/files#diff-a717dcbee90c573feec0be98675c64ff06bf5bb3d8bb3d30b66b131952e22a3cR169), it return three values, but the client only uses two (ok, err), is it a bug? should we fix it?
I notice that there is some code (https://github.com/ledgetech/lua-resty-http/pull/307/files#diff-a717dcbee90c573feec0be98675c64ff06bf5bb3d8bb3d30b66b131952e22a3cR169), it return three values, but the client only uses two (ok, err), is it a bug? should we fix it?
Yeah, I think so. Fixed them.
@pintsized I think this is good to go now.
Great work everyone, thank you!
@pintsized Could you bump a new version? Appreciate it.
@pintsized Could you bump a new version? Appreciate it.
0.17.2 is now on luarocks. I'm having some issues with opm, but it will be there once resolved.