LedgerSMB icon indicating copy to clipboard operation
LedgerSMB copied to clipboard

Use of overpayments is broken

Open einhverfr opened this issue 7 months ago • 6 comments

Version

12.8

What browsers are you seeing the problem on?

This problem isn't browser related

What happened?

To to use AR overpayment. Enter customer etc info.

Try to use an overpayment. Nothing happens. Update does not add the invoice. Post posts nothing.

What should have happened?

For consistency I believe what should happen is that the invoices hsould be listed here on hitting update, and then one should be able to use an overpayment against one or more invoices.

einhverfr avatar Jun 02 '25 11:06 einhverfr

So digging in a bit more, I don't think this has ever worked fully. I found at least one bug I fixed and tested but another bug cropped up.

The search issue is because critical information is not being set from the request as expected but an object which has lost some of the data. If I fix that then the search works, and repeatedly clicking update works as expected, but if I add an amount and click update, the form data becomes corrupted and post won't work. Post also doesn't work before I click update.

einhverfr avatar Jun 02 '25 12:06 einhverfr

At this point I'm convinced overpayments have never worked to a level that is useable. I think we shouldn't advise people to use it until we have reimplemented it.

ehuelsmann avatar Jun 02 '25 20:06 ehuelsmann

See the issues in the linked project for more context of that statement.

ehuelsmann avatar Jun 02 '25 20:06 ehuelsmann

Duplicate of #4588 ?

ehuelsmann avatar Jun 03 '25 06:06 ehuelsmann

Duplicate of #4588 ?

Not a duplicate but there is an additional problem here I have not fully traced, which is that some customers don't seem to work when selecting them and clicking update. So it is yet another bug.

This one has two bugs.

  1. Repeated updates mangles due and date fields, and
  2. Post does nothing.

The bug you refer to I have run across here, but I haven't been able to trace where it happens, and it affects some customers on my system but not others. So it needs more independent investigation.

einhverfr avatar Jun 10 '25 10:06 einhverfr

#4588 appears to either be stale or a UX problem. UX is improved with my on-going patches and I cannot reproduce it at present.

At present the mangling has been fixed and on to the posting.

einhverfr avatar Jun 11 '25 06:06 einhverfr