LedgerSMB
LedgerSMB copied to clipboard
oe.id and transactions.id no longer share a sequence
Consequences of the fact that they do not share a common sequence anymore:
-
statustable data from orders is linked to invoices and vice versa; invoice status may overwrite/add to orders data - Recurring orders don't work (I've even hidden the buttons). It hasn't worked for 14 years (due to overlapping number ranges in
oe.idversustransactions.id) and has been aggravated for the last 8 years by an integrity constraint ofrecurring.idagainsttransactions.id, completely blocking the ability to add schedules to orders, except when there's accidental overlap in the number ranges (which is more likely to be hazardous than a intentional.) -
goods__history(https://github.com/ledgersmb/LedgerSMB/blob/33c601fdb8ebfa3c012d2773e388c3e679aa2a99/sql/modules/Goods.sql#L519-L525) joinstrans_idretrieved from both oe as well asar/ap(i.e.transactions), which is similarly broken to recurring orders
I'm not sure the fact that they no longer share a series is a bug (I don't think so); the knock-on effects are unintentional, though. Definitely regressions.