Report buffer not finding ledger executable

[titanofold]

Hi, all!

When running a report, I'm getting the following result:

Report: bal
Command: "ledger" -f "c:/Users/aswenson/Dropbox/financial/demo.ledger" bal
=====================================================================================================================

'"ledger"' is not recognized as an internal or external command,
operable program or batch file.

I believe this line needs executable-find: https://github.com/ledger/ledger-mode/blob/19b84dc7664ea069e1a9fd446daf699574c44986/ledger-report.el#L241

As otherwise ledger-mode appears to operate OK.

[purcell]

executable-find just looks up an executable on the current path, but it should make no difference here, because if a plain executable name is provided then Emacs will resolve it from the current path automatically. What's suspicious to me is the double quotes around ledger. If I recall correctly, it's not safe to do that on some platforms. I might guess that the right fix here would be to not call shell-quote-argument on ledger-binary-path. Perhaps you could try that out locally?