Fabrice Normandin

Results 132 comments of Fabrice Normandin

Also, if we don't expect calling __init__ with a seed, we shouldn't enforce that behaviour with the test_rng_init tests in the BaseAlgoTests class. I mention this in #886

Also, there's also a bit of a disconnect between the string format and the `Dimension` classes. For instance: - `"uniform(0, 10, discrete=True)"` --> `Integer(low=0, high=10, prior="uniform")` - `"uniform(0, 10)"` -->...

Hey there @Rahul-Choudhary-3614 , thanks for posting this! I'll try to reproduce your error, but in the meantime, I have some questions: - What version of Orion are you using?...

## Good asserts Here's my take what makes a "good" assert: - **affirms** things that are already true. - doesn't *check* that something is true! Very important! That's the role...

Just to add to this: if all the objectives are None, the code below still works: https://github.com/lebrice/orion/blob/18fd691bbf22762f8175ccf27a1a190a95f33a39/src/orion/algo/hyperband.py#L631-L635 During tests, we don't encounter an issue here, because either all the objectives...

Minor clarification: Some older tests that were being silently skipped were re-enabled, and since they were created before the last modifications to TPE, some of them failed, or used a...

Might be a good idea to review what is currently here. From my perspective, the main thing left is to add is some unit tests.

What do you think of FastAPI? https://fastapi.tiangolo.com/#example I don't know these tools personally, but this looks intersting to me

It could be worth taking the time to investigate it and actually try it out before ruling it out, since if it indeed does makes the code very clean and...