Fabrice Normandin

Results 132 comments of Fabrice Normandin

Hello there @aliounis , thanks so much for posting this! I'll try to look into this soon, but if you feel up to it and have time, sure, go ahead...

Thanks for posting @stas00 , I'll take a look!

Hello there @tcapelle, sorry no work has been done on this in a while. I will take a look when I find the time, but you're more than welcome to...

Hey there @aliounis , thanks for making this PR! I think this kind of change could benefit from a unit test or two. Do you feel up for the "challenge"?...

Here's what this kind of unit tests could look like. Feel free to add more tests and/or test cases, in particular for the second bug you mentioned. ```python import pytest...

Yes, all tests are required to pass for anything to be merged to Master. Therefore, it seems like your changes did break a test or two. I'm here to help,...

Hello there @pfrwilson, thanks for posting! Good catch, there does seem to be some statefullness going on with the parse_known_args. I'll take a look. By the way, are you familiar...

Hey there @pvandyken , thanks for posting this. Sorry I didn't get to it, I was not checking GitHub during the holidays. Yes, you're right, good catch. This doesn't really...

Ok I'm not quite sure that this is an issue anymore. Let me try to explain. If a field has a default value, then it is necessarily an _optional_ argument,...

:thinking: This makes sense. I'll keep thinking about this one for a bit, I'll get back to you.