Nico Haas

Results 14 comments of Nico Haas

Closing since we have now an OAuth flow for retrieving the token instead of via a single REST Call before.

You left a comment for`getMetrics` in [cli/session.go](https://github.com/clouditor/clouditor/blob/e5c370810297a6ef4880806aa9bba14f176355be/cli/session.go) as well: `// TODO(oxisto): This could be an interesting use case for 1.18 Go generics`

I wouldn't close it since it is a possibility that an empty request is sent (nil value since it is a pointer). I will address it in #566

> Would it make sense to pipe this information into logrus as additional fields? similar to the way it is done for gRPC requests? This would then separate the logic...

What was the input resulting in that error message? The problem is that we only have a map and no struct. And the values of that map are checked via...

But converting the map to a struct would mean to first convert it to a struct, check its values and then use the map anyway. Since rego only accepts a...

I also find that quite confusing. Is there an opinion on this from the developers? Thanks!

> Ah, it seems all the filter of the service were merged into a single one. Looks like we need distinct filter objects and then the question is: Is that...