cocoapods-binary icon indicating copy to clipboard operation
cocoapods-binary copied to clipboard

Published 20 hours ago • verified publisher icon leavez

Shell-escaped the project path that we use for xcodebuild and lipo.

Open antonino-u opened this issue 5 years ago • 4 comments

Resolves issue #88. Shellwords is built into Ruby, see the doc for what it does here: https://ruby-doc.org/stdlib-2.0.0//libdoc/shellwords/rdoc/Shellwords.html

In short, a path string like /hello world' becomes suitably escaped for shell use, and transformed into /hello\ world`.

.shellescape was added to string variables passed to both xcodebuild and lipo, and now things work as expected when there are characters (like spaces) that need to be escaped in the file paths.

antonino-u avatar Aug 24 '19 17:08 antonino-u

Please Note: the failing build has nothing to do with my change...

antonino-u avatar Aug 24 '19 18:08 antonino-u

I can confirm and reproduce same issue in our project, and can confirm this PR fixes it. Would be great if this PR could be merged @leavez

MariuszWisniewski avatar Mar 24 '20 17:03 MariuszWisniewski

I can also confirm that it's an issue with projects where the build scheme contains spaces. This PR fixes the problem, please consider merging @leavez

NathanielBlackburn avatar Mar 25 '20 09:03 NathanielBlackburn

This PR fixes the problem with spaces in build scheme. Please merge it @leavez

ghost avatar Mar 26 '20 09:03 ghost