cocoapods-binary icon indicating copy to clipboard operation
cocoapods-binary copied to clipboard

Fix license warning with subspecs

Open kylefleming opened this issue 4 years ago • 2 comments

CocoaPods-binary removes the license attribute from the podspec attributes hash since it doesn't copy the license file over. However, the license attribute in only valid in the root spec of a podspec.

There is currently a bug where if you specify a dependency on a subspec of a pod, then cocoapods-binary removes the license attribute not from the root spec, but from the subspec, thus leaving the license attribute in the root spec intact. This produces the following warning:

[!] Unable to read the license file `LICENSE` for the spec `<PodName> (<PodVersion>)`

This PR fixes this bug by using the root spec when removing the license attribute.

kylefleming avatar Apr 18 '20 03:04 kylefleming

Faced with the same issue. It'd be awesome to merge this one.

anton-plebanovich avatar Jan 30 '21 13:01 anton-plebanovich

I was able to reproduce with pod 'Moya/Core', :binary => true

anton-plebanovich avatar Jan 30 '21 14:01 anton-plebanovich