extension icon indicating copy to clipboard operation
extension copied to clipboard

Several Stacks NFTs not showing in wallet

Open brandonmarshall-tm opened this issue 10 months ago • 7 comments

I have several examples of Stacks NFTs not displaying at all in Leather. These all seem to be related to Hiro's API, so we would probably need to work with them resolve it. But since they are not displaying in our wallet, wanted to capture the issue here.

All of them produce Console errors like this: non-fungible-token-metadata.query.ts:40 GET https://api.hiro.so/metadata/v1/nft/SP1CE3NQXDKCJ2KEFFGCVFA5C196S9F0RRX93HY87.pizza-ninjas-on-sothebys/2 404 (Not Found)

Examples of more Collectibles that do not display: SPQ5CEHETP8K4Q2FSNNK9ANMPAVBSA9NN86YSN59.stxstone SP1CE3NQXDKCJ2KEFFGCVFA5C196S9F0RRX93HY87.pizza-ninjas-on-sothebys SP25W1B7YX3F20S598J4EXEE9HZ0XHY6PNVTT6FA3.trajan-endorse-v0_1_0

brandonmarshall-tm avatar Apr 23 '24 22:04 brandonmarshall-tm

Adding that the Pizza Ninjas and STXSTONES do display in Gamma: https://stacks.gamma.io/collections/pizza-ninjas-on-sothebys/2 https://stacks.gamma.io/collections/stxstone/5326

brandonmarshall-tm avatar Apr 23 '24 22:04 brandonmarshall-tm

Issue reported to Hiro https://github.com/hirosystems/explorer/issues/1591

DeeList avatar Apr 24 '24 05:04 DeeList

image

These are not loading in the wallet.

Among them is the recently popular majo NFT's https://api.hiro.so/metadata/v1/nft/SPNWZ5V2TPWGQGVDR6T7B6RQ4XMGZ4PXTEE0VQ0S.mojo/135

image

314159265359879 avatar Apr 28 '24 21:04 314159265359879

https://github.com/hirosystems/explorer/issues/1591#issuecomment-2093829686

DeeList avatar May 04 '24 00:05 DeeList

Another report of NFT's not being displayed in Leather, while other wallets (and stacks.gamma.io) do display them https://stacks.gamma.io/SP30ND6RAZT4K2S8NQKYFTQ4GXT2WX4VMCQPHS24T?tab=collected

relevant contracts: SP229HYJZF8F2R6BYGJZENTY2MB8W1HRYKXTA9RZR.runedom and SPQ3TT36JN77TSPVXC70RZ4STZF4Y0PWT6VPJE82.fehudom

314159265359879 avatar May 17 '24 09:05 314159265359879

Here is another user report, basically none of these are displaying in Leather and also not displaying correctly in Hiro (but do display correctly on Gamma)

https://explorer.hiro.so/address/SP2QP89JZACDW214Q5H2N3WJWXV5N5GKMA7HNPZ41?chain=mainnet https://stacks.gamma.io/fortnakamoto.btc

brandonmarshall-tm avatar May 17 '24 17:05 brandonmarshall-tm

Created a Stacks-specific issue for this: https://github.com/hirosystems/explorer/issues/1634

brandonmarshall-tm avatar May 17 '24 17:05 brandonmarshall-tm

Related, possible solution in case we can't show an image: https://github.com/leather-wallet/extension/issues/3290

314159265359879 avatar May 20 '24 14:05 314159265359879

@brandonmarshall-tm it's perhaps best to post your issue above in the metadata API repo?

markmhendrickson avatar May 21 '24 11:05 markmhendrickson

Done: https://github.com/hirosystems/token-metadata-api/issues/218

brandonmarshall-tm avatar May 21 '24 14:05 brandonmarshall-tm

This issue can be resolved! The only NFTs not showing are ones not following SIP-016 standard, but the main ones that were previously missing (like Nakamojo and Project Indigo) are displaying now.

brandonmarshall-tm avatar Jun 04 '24 03:06 brandonmarshall-tm

There are some older NFTs and newer like the Stacks original Nakamojo NFT https://explorer.hiro.so/txid/SPNWZ5V2TPWGQGVDR6T7B6RQ4XMGZ4PXTEE0VQ0S.mojo?chain=mainnet and Stacking DAO NFT https://explorer.hiro.so/txid/SP4SZE494VC2YC5JYG7AYFQ44F5Q4PYV7DVMDPBG.stacking-dao-genesis-nft?chain=mainnet that do not display in Leather but show in Gamma.

nfts nft2

DeeList avatar Jun 04 '24 03:06 DeeList

I do not see Mojo loading either. And a couple more: https://explorer.hiro.so/token/SP3D6PV2ACBPEKYJTCMH7HEN02KP87QSP8KTEH335.megapont-ape-club-nft?chain=mainnet https://explorer.hiro.so/token/SP497E7RX3233ATBS2AB9G4WTHB63X5PBSP5VGAQ.boom-nfts?chain=mainnet https://explorer.hiro.so/token/SPGGAEQWA7Y9HRZY5T0XJCEYEZ28J6RKCCC1HP9M.chicken-and-mayo-music-nft?chain=mainnet https://explorer.hiro.so/token/SPJW1XE278YMCEYMXB8ZFGJMH8ZVAAEDP2S2PJYG.stacks-pops?chain=mainnet https://explorer.hiro.so/token/SPNWZ5V2TPWGQGVDR6T7B6RQ4XMGZ4PXTEE0VQ0S.monkey-coin?chain=mainnet

These show up but they show with the image the contract was deployed with (placeholder, the same for every NFT in the contract) instead of the revealed images per NFT: https://explorer.hiro.so/token/SP2BE8TZATXEVPGZ8HAFZYE5GKZ02X0YDKAN7ZTGW.arties?chain=mainnet

314159265359879 avatar Jun 04 '24 07:06 314159265359879

@DeeList @314159265359879 has the Mojo issue been reported to Hiro, and if not, mind creating an issue in their API repo and cross-linking here to keep track?

In general, I'd recommend that we keep this extension-specific issue closed unless we uncover a problem with its code per se. Otherwise, it's not entirely clear whether we need to fix something with the extension on our end.

markmhendrickson avatar Jun 17 '24 11:06 markmhendrickson