extension icon indicating copy to clipboard operation
extension copied to clipboard

integrate LNSwap

Open pseudozach opened this issue 1 year ago • 3 comments

fixes #4558

some open design/UX questions on this:

  • How to enable a swap LNBTC -> STX when LNBTC balance is 0 ?
  • How should we take an LN invoice input from the user in case of STX -> LNBTC ?
  • Should lnswap sdk return a transaction for leather to sign (similar to what Alex SDK does) or can I just return created swap data that includes the contract address, amount and contract call parameters and prepare the payment on leather repo lnswap related components?

pseudozach avatar Feb 14 '24 09:02 pseudozach

@pseudozach thanks! Mind including a screen recording walkthrough of how this currently works?

markmhendrickson avatar Feb 14 '24 14:02 markmhendrickson

How to enable a swap LNBTC -> STX when LNBTC balance is 0 ?

Can you elaborate on this. How would you be able to swap in the first place if your balance is zero? Is that how it works?

Other questions are design related. ~Do we have designs for LNSwap specific swapping flows?~ Edit see them here.. Imagine we need to update these with the latter questions re accepting invoice etc.

kyranjamie avatar Feb 15 '24 11:02 kyranjamie

How to enable a swap LNBTC -> STX when LNBTC balance is 0 ?

Can you elaborate on this. How would you be able to swap in the first place if your balance is zero? Is that how it works?

Other questions are design related. ~Do we have designs for LNSwap specific swapping flows?~ Edit see them here.. Imagine we need to update these with the latter questions re accepting invoice etc.

I meant if user wants to use some other way to pay a Lightning invoice and then receive STX in their leather wallet. how do we enable that? I noticed in the codebase if a balance is 0, it wont show up in the list of swap pairs.

also I'm still trying to find an alternative way to test this end to end since both bitcoin and stacks testnet are unusable. I'll try to have a demo on regtest - devnet soon.

pseudozach avatar Apr 27 '24 05:04 pseudozach

This was an investigatory PR which now isn't being worked on. Closing.

kyranjamie avatar Jun 17 '24 08:06 kyranjamie