extension icon indicating copy to clipboard operation
extension copied to clipboard

Design System: Address

Open mica000 opened this issue 1 year ago • 5 comments

mica000 avatar Feb 02 '24 13:02 mica000

FYI @fabric-8 added the address as a ticket

mica000 avatar Feb 05 '24 15:02 mica000

What dev feedback is needed here?

fbwoolf avatar Feb 11 '24 16:02 fbwoolf

Saw some conversation on Figma, but curious why we landed on removed the alternating colour?

The spacing and the colour are the two visual "hooks" that help you easily refer back to the last place you looked when checking it's correct when depositing to a exchange, or writing down on paper. I thought it's a really clever technique, and that it's something we do better than other wallets. Removing one of them is a backwards step imo.

kyranjamie avatar Feb 12 '24 08:02 kyranjamie

@kyranjamie Yes, we were debating because since the updated radix on the colors, the alternative we would have to rely on would be text-subdued, however this was lacking on contrast, hence result wasn't good.

Last week I saw that 1password is solving this by applying blue to numbers, and it seems to solve it better. Here is how it could possibly work. Let me know your thoughts

https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=11410-32620&mode=design&t=WRVcQ8oVMuk8v73S-4 image

mica000 avatar Feb 12 '24 11:02 mica000

@fbwoolf this component is now ready in designs. We settled for the alternating color to be color-subdued

mica000 avatar Feb 14 '24 12:02 mica000