extension icon indicating copy to clipboard operation
extension copied to clipboard

Increasing the fee on some bitcoin transactions errors with "Writer(): uInt: value out of bounds"

Open 314159265359879 opened this issue 7 months ago • 5 comments

The user explained it was a transaction they created with Magic Eden to transfer some rare sats to the ordinals wallet on Leather.

I have seen one other report but no examples of affected transactions. I will add them when users share them here.

The error in the screenshot in the next comment pops up after the user clicks "submit" on the fee increase screen.

314159265359879 avatar Jan 08 '24 23:01 314159265359879

image

314159265359879 avatar Jan 08 '24 23:01 314159265359879

Example of another transaction that will throw this error when trying to increase the fee: https://mempool.space/tx/ceb437c902132022dbaaea2feb754241253ddaa539b74c16114bcc619fc1fb31 image image

This is the payment transaction (I am not sure if this is relevant but the dapp creates this subsequent transaction with the first output... for the actual token mint: https://mempool.space/tx/ec1ad7ed5ce1f4e2a5db8367d26c4b6a9447dce53923f3c97d080fbea0ab7648)

This is from stampscan.xyz, minting SRC20, steps to reproduce

  1. Sign in with Leather
  2. Click mint
  3. Add values like this (or choose another token) PXL, 3141, 2, and set a fee rate. image
  4. Proceed
  5. Sign transaction
  6. Then increase the fee via the activities tab in the wallet
  7. See this error image

In this case the RBF flag is false, the wallet should apply CPFP to increase the fee. The error doesn't help users, it should be prevented. Users want the ability to increase the fee on any type of transaction.

On mobile/kiwi a user reported seeing a different error (Error: transaction size must be defined) instead. I was not able to reproduce but they said also seeing it on desktop, this error occurs on step 6 in the flow mentioned above:

https://github.com/leather-wallet/extension/assets/33360391/4d758958-1922-4e39-8850-16f097e975f4

314159265359879 avatar Feb 08 '24 09:02 314159265359879

I saw another case like this today. It was for this incoming transaction https://mempool.space/tx/811fd8009595ae3b45034d07c37277654b2c28834350c503aa47f29a2c52e005

The user tried "increase fee" on this transaction and lead to the same error.

I do not expect the increase fee option to show on incoming transactions currently.

I think the bug was that the button, to increase fee, should not have been shown in the first place.

314159265359879 avatar Apr 12 '24 10:04 314159265359879

Another transaction that had the "increase fee" option shown to the user but the transaction doesn't support RBF so it shouldn't have. As they tried to increase the fee they saw the same "out of bound" error. image

https://mempool.space/tx/521f8645c74b8ceb381954772e6de858992d59e02cbbfed9552afc10377e3324

In this case CPFP would have been an option. It would be great if users can click increase fee and the wallet can pick CPFP/RBF whatever is applicable depending on the type of transaction.

The user noted that they had trouble copying the error text, it would help users if their was some kind of error log they could access to see past error messages.

314159265359879 avatar Apr 13 '24 22:04 314159265359879

i'm having the same issue with increasing the fee. i increased the fee about 20 minutes ago just fine. but wanted to increase again by a little bit and it gave me the same error "out of bounds". no RBF support for the transaction as well. the wallet extension (chrome) shows "increase fee" button

zalupapeti avatar Apr 17 '24 22:04 zalupapeti