extension icon indicating copy to clipboard operation
extension copied to clipboard

Design System: Add toast

Open mica000 opened this issue 1 year ago • 9 comments

image

https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=12108-63748&mode=design&t=4atOHlKRSOr96Vb7-4

mica000 avatar Oct 03 '23 11:10 mica000

And this a callout per https://www.radix-ui.com/themes/docs/components/callout

kyranjamie avatar Oct 03 '23 12:10 kyranjamie

@kyranjamie are you sure, this looks and behaves more like https://www.radix-ui.com/primitives/docs/components/toast

mica000 avatar Oct 03 '23 12:10 mica000

Looks like, but doesn't behave like. A toast is a global element which often appears over other content in top-right/bottom-right of screen (not inline like displayed here).

kyranjamie avatar Oct 03 '23 12:10 kyranjamie

Sorry this was lacking further description. The behavior or for this component is indeed to appear over the content and then disappear

mica000 avatar Oct 03 '23 12:10 mica000

@mica000 to provide standard positioning guidance, across modal and full width tab formats

markmhendrickson avatar Oct 23 '23 15:10 markmhendrickson

@fabric-8 could you also take a look into this one? It's missing the visualisation of how toasters would work on different sizes

mica000 avatar Jan 08 '24 15:01 mica000

@mica000 I think the confusion here (toast vs. callout) partially stems from this looking quite like a callout - Mind if I suggest a slightly different design looking more like a toast floating on top?

fabric-8 avatar Jan 09 '24 14:01 fabric-8

@mica000 I think the confusion here (toast vs. callout) partially stems from this looking quite like a callout - Mind if I suggest a slightly different design looking more like a toast floating on top?

Of course not :D All yours!

mica000 avatar Jan 09 '24 15:01 mica000