extension icon indicating copy to clipboard operation
extension copied to clipboard

Published 20 hours ago • verified publisher icon leather-wallet

Incorporate standard receive modal for inscriptions

Open markmhendrickson opened this issue 2 years ago • 5 comments

We're currently trying to fit a lot / too much into one modal for inscription deposits:

Image

We'd also like to display the full address so the user doesn't have to trust just the copy-to-clipboard functionality.

We should break the current modal into two modals shown sequentially after the user selects "Ordinal inscription" from the "Add collectible" modal:

  1. Informative modal that indicates where the user can inscribe (Gamma, Ordinalsbot) and warns only to deposit inscriptions, with a "Proceed" button
  2. Standard receive modal with QR code and full address displayed, with "Copy to clipboard" button

Image

markmhendrickson avatar Feb 24 '23 23:02 markmhendrickson

As we tackle this flow, let's also clarify that:

  1. We regenerate this address each time for privacy purposes
  2. It's okay to deposit multiple inscriptions into each address shown (i.e. they won't get lost, and you'll be able to see and send all of them from the wallet)

Additionally, we may want to add an option to either A) regenerate the address (for privacy 🕵️) or B) reuse the same address (for social sharing 👨‍👩‍👧‍👧). Though it deserves more team discussion first.

We should also probably provide an easy way to view previously shown addresses from this flow, even if it's a simple list, as we figure out a more integrated solution for browsing addresses by type in the wallet.

@mica000 when you get to this issue, let's discuss whether it's worth taking on all of the above at the same time or decomposing further.

markmhendrickson avatar Mar 09 '23 12:03 markmhendrickson

PART 1 - RECEIVE UX

@markmhx, Had to change a bit the design of the current modal so that everything can fit. The past design had a lot of space being unused.

The new design now can handle:

  • Notification
  • Descriptive Text
  • Wallet type
  • CTA to recover past addresses (Ordinal use case)

https://www.figma.com/file/OSQocEEJnfcMkniEl8u3U8/%231483---Initial-Bitcoin-support?node-id=1908-87351&t=aN1XBe9LZW9tw8mp-4

mica000 avatar Mar 09 '23 18:03 mica000

Updated designs: https://www.figma.com/proto/OSQocEEJnfcMkniEl8u3U8/%231483---Initial-Bitcoin-support?page-id=1065%3A45572&node-id=1182%3A64629&viewport=855%2C674%2C0.1&scaling=min-zoom&starting-point-node-id=1182%3A64633

mica000 avatar Mar 09 '23 22:03 mica000

Looking good! Assigning back though since I've added some Figma comments, and it seems the list of all Taproot addresses is missing from the set?

markmhendrickson avatar Mar 13 '23 13:03 markmhendrickson

@edu-stx @markmhx

Here is the newest user flow: https://www.figma.com/file/OSQocEEJnfcMkniEl8u3U8/%231483---Initial-Bitcoin-support?node-id=1182-64633&t=KrrJ8n7OQXEcbt9x-4

Components can be seen here: https://www.figma.com/file/Li7qK8ZIG9c5dKSNOPO4iCtv/%E2%9D%96-Design-System?node-id=4147-13824&t=PA1PRhKz9ZYKpsRf-4

mica000 avatar Mar 13 '23 17:03 mica000