extension icon indicating copy to clipboard operation
extension copied to clipboard

fix: slow firefox sign in times

Open kyranjamie opened this issue 3 years ago • 1 comments

Try out this version of the Hiro Wallet - download extension builds.

🚧 EXPERIMENTAL

This PR moves the slow key stretching derivation logic from a Web Worker to the background script.

Tagging Firefox users from the issue #2014 and others. If you have time to help test this solution and affirm it speeds up unlock times, that'd be very helpful @neorrk @zommuter @friedger @fluidvoice @Hero-Gamer @pors

kyranjamie avatar Sep 16 '22 12:09 kyranjamie

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
stacks-wallet-web ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 0:34AM (UTC)

vercel[bot] avatar Sep 16 '22 12:09 vercel[bot]

Closing this PR as the other attempt at speeding up the WebWorker works better

kyranjamie avatar Oct 12 '22 12:10 kyranjamie

sorry. I just got around to installing this on Firefox. It's working and navigation is faster, more responsive. I'll continue using it and see how it is.

fluidvoice avatar Oct 13 '22 00:10 fluidvoice

@fluidvoice did you try the build on this exact PR or the one on https://github.com/hirosystems/stacks-wallet-web/pull/2666?

markmhendrickson avatar Oct 13 '22 08:10 markmhendrickson

@fluidvoice did you try the build on this exact PR or the one on #2666?

I first tried this exact PR which fixed the problem, then later I discovered and tried refs/pull/2712/merge which still had the problem. Using this, the app was overall much more responsive/fast.

fluidvoice avatar Oct 13 '22 11:10 fluidvoice

I made two PRs that attmpted to fix this issue. This one, that I closed, fixes the issue on Firefox but causes issues on Chromium. #2712 has nothing to do with fixing this issue.

This build is the one we propose to merge 👉🏼 https://github.com/hirosystems/stacks-wallet-web/pull/2666

kyranjamie avatar Oct 13 '22 12:10 kyranjamie

we propose to merge 👉🏼 #2666

this is working for me.

fluidvoice avatar Oct 13 '22 12:10 fluidvoice