extension
extension copied to clipboard
leather-wallet
feat(ledger): add utf-8 message signing support
Try out this version of the Hiro Wallet - download extension builds.
WIP.
This PR adds support for UTF-8 message signing for Ledger.
I've refactored many duplicated components, yet retained an approach where each Ledger interaction is composed of generic components, making use of Route state where action-specific textual changes are needed. The current set up allows each Ledger action to either use the generic component if sufficient, or a bespoke component if necessary.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| stacks-wallet-web | ✅ Ready (Inspect) | Visit Preview | Sep 6, 2022 at 11:50AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Made a first pass through, looks like some good improvements while adding the message signing flow. 👍 I saw you moved the routes in with the feature which is interesting.
To clarify, that is when on testnet > using test-app > clicking on a button to sign a message.
EDIT: And, performing a contract call is successful.
Did you checkout branch or try the build directly? If former, make sure to yarn, this is an error from old version of connect afaict
Did you checkout branch or try the build directly? If former, make sure to
yarn, this is an error from old version of connect afaict
This was from the latest downloaded build. I can try again today.
Did you checkout branch or try the build directly? If former, make sure to
yarn, this is an error from old version of connect afaict
Does the test-app need to be run from this branch? That I am running locally.
Does the test-app need to be run from this branch? That I am running locally.
Yes, with latest packages
@kyranjamie ok, I am seeing this with the Signature (Testnet) button:
Signature with line breaks is no longer breaking the lines? Also, it is successful but doesn't close the popup.
Signature with long message is successful, but doesn't close the popup on success.
Maybe it never broke the lines on that screen? It does on the details screen before so was thinking it did.
Thanks for the feedback @fbwoolf—sorry totally forgot that we're also waiting on these changes in Stacks.js https://github.com/hirosystems/stacks.js/pull/1329
Signature with long message is successful, but doesn't close the popup on success.
Fixed, had it not closing for debugging purposes