extension icon indicating copy to clipboard operation
extension copied to clipboard

Published 20 hours ago • verified publisher icon leather-wallet

Allow to transfer assets to a bns name

Open friedger opened this issue 2 years ago • 5 comments

Currently, bns names are not accepted as recipients

Screenshot from 2021-10-19 10-19-16

Expected behaviour Allow to enter a bns name in preview and show the resolved address + bns name in final screen

friedger avatar Oct 19 '21 08:10 friedger

Yes please, big +1

xanbots avatar Oct 19 '21 08:10 xanbots

+1 (we have the demand!)

sleepiJoe avatar Jan 29 '22 23:01 sleepiJoe

What should the UI look like? Should the preview just show the address and the name?

friedger avatar Apr 28 '22 13:04 friedger

Assigning @landitus to design

markmhendrickson avatar Apr 28 '22 13:04 markmhendrickson

Interesting comment here: https://twitter.com/axopoa/status/1519572653278908417

I think we will need a autorenewal service for BTC names. Because it can be very dangerous if someone renews a name you own before you do.

pors avatar Apr 28 '22 14:04 pors

From @kyranjamie:

Would be a great feature, but it isn't entirely trivial. We need to consider homoglyph attacks: I could buy bruffstаr.btc (Cyrillic letter а). We need to show address still in UI and warn against dodgy chars, similar to how vscode does

markmhendrickson avatar Sep 29 '22 10:09 markmhendrickson

homoglyph attacks are not possible because names are limited to a-z, 0-9 and - and _

friedger avatar Sep 29 '22 10:09 friedger

That does indeed limit the scope. We should still use a clear display type, so Oliver.btc is visibly different to OIiver.btc (capital i not L).

kyranjamie avatar Sep 29 '22 12:09 kyranjamie

That does indeed limit the scope. We should still use a clear display type, so Oliver.btc is visibly different to OIiver.btc (capital i not L).

only lower case letters are allowed in BNS names

aulneau avatar Oct 20 '22 18:10 aulneau

+1 for BNS names in recipient fields.

RagnarLifthrasir avatar Oct 20 '22 20:10 RagnarLifthrasir

A blocker is still https://github.com/hirosystems/stacks-blockchain-api/issues/1333

friedger avatar Oct 20 '22 22:10 friedger

A blocker is still hirosystems/stacks-blockchain-api#1333

does not need to be a blocker, you can use the NFT history endpoint (gamma does this)

see https://discord.com/channels/621759717756370964/909867922971820102/1033008587804520459

yes, you can use the NFT history endpoint but you'll have to provide the name Clarity encoded. This is an example for eliherf.stacksparrot: https://stacks-node-api.mainnet.stacks.co/extended/v1/tokens/nft/history?asset_identifier=SP000000000000000000002Q6VF78.bns::names&value=0x0c00000002046e616d650200000007656c6968657266096e616d657370616365020000000c737461636b73706172726f74

aulneau avatar Oct 21 '22 13:10 aulneau

does not need to be a blocker, you can use the NFT history endpoint (gamma does this)

How do we reach all developers to switch from one api endpoint to the other? Seems not an option

friedger avatar Oct 22 '22 09:10 friedger