extension
extension copied to clipboard
leather-wallet
Prevent app from switching network automatically, require explicit user permission
Following on from #1280
How it works now Connected apps can open transactions that transparently switch between a network other than the one your wallet is currently set to, provided its in your list.
Why this is a problem
- It's unexpected: We provide no guidance/feedback that this switching happens (a user can only tell if they select the network switcher, or notice their balance is different)
- An attack vector exists: Consider you're in mainnet mode. A malicious "testnet" app guides you to switch to testnet. "Great, I'm operating in a safe environment" you think. The app reassures you "You're in testnet mode". Now send me "testnet" STX, and the transaction window opens—the app switches it to a mainnet transaction and you don't notice the network mainnet label ⚠️
Solution We implement the following behaviours:
- The wallet can only operate in one network mode at any given time
- The user must give their approval for an app to change network (regardless of whether you have it saved)
The flows are then:
See EIP-2015 best practices which notes similar function.
cc/ @jasperjansz @fbwoolf @andresgalante @aulneau
I'm on board, big improvement. Should we also remove the ability to switch network in the tx signing screen? It will just lead to the contract not being found.
big +1 for me. I think the only thing we should really allow is to switch user, but also warn them about that.
Similar to this is an app can be signed into one account, but the user could be on a different account. Do we want to show a warning for this too?
a thing I'd like to avoid is having multiple pop ups in our window
Connected apps can open transactions that transparently switch between a network other than the one your wallet is currently set to, provided its in your list.
Is this still true these or have we resolved this issue by now?
True. This remains an issue, we've never built a change network confirmation screen.
Coinbase Wallet has added this same functionality/flow
we have also added support for EIP-3085, which allows dapps to suggest a specific network to the user. When a dapp wants to suggest a network that differs from the user’s current network, Coinbase Wallet will ask the user to confirm the switch.