Refactor: software wallet to persist public key, not address

[kyranjamie]

Prerequisite for https://github.com/blockstack/stacks-wallet/issues/397 https://github.com/blockstack/stacks-wallet/issues/402

Currently the software wallet persists the STX address, while Ledger's persis the public key. This was a poor choice.

Both wallets should persist the public key too, deriving the address from that.

While the refactor work itself won't be very difficult, the upgrade path for existing users needs consideration.

[He1DAr]

@timstackblock @Eshwari007 this one is ready for QA, the refactor touches multiple parts, would be great if we test all critical paths, including:

1. New users for both software and ledger (Should be the same use experience)
2. Existing (signed in) users updating to the new version for both software and ledger (they should be prompted to new Unlock page)
3. Forget password / Reset wallet from settings / Sign in churn More info on the implementation PR https://github.com/hirosystems/stacks-wallet/pull/1056

Let me know if you need anything from my end.

[timstackblock]

The windows wallet is broken and gives a nasty Javascript error when trying to send STX with a ledger Nano S see a video of the bug here http://somup.com/c3e3qYT755

Once I hit the bug the wallet become unresponsive

[He1DAr]

The file HID.node, which is located at {INSTALL_DIR}\resources\app.asar.unpacked\node_modules\node-hid\build\Release doesn't exist when installing this build, @kyranjamie have you experienced similar issue before?

[kyranjamie]

Does this happen consistently between builds? I've ran into issues in the past where, the services that hosts the platform-specific binaries is down, so its unable to get these files.

Can you replicate the issues when building locally yarn build:testnet && yarn start?

[He1DAr]

Does this happen consistently between builds? I've ran into issues in the past where, the services that hosts the platform-specific binaries is down, so its unable to get these files.

Can you replicate the issues when building locally yarn build:testnet && yarn start?

Couldn't find yarn build:testnet, does yarn build work locally for you?

[kyranjamie]

sorry I couldn't remember the syntax, it's STX_NETWORK=testnet yarn build

[Eshwari007]

Moving the issue back to Development as the error issue above is reproducible on Windows 10 Home cc @He1DAr @andresgalante

[andresgalante]

Thanks @Eshwari007

@markmhx lets sync on next steps for this issue