studio icon indicating copy to clipboard operation
studio copied to clipboard

[KDS to Studio] Migrate 'Failed to delete account' alert from Vuetify to Kolibri Design System

Open MisRob opened this issue 7 months ago • 4 comments

🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:

  • Read the Contributing guidelines carefully. Pay extra attention to the Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
  • Confirm that you’ve read the guidelines in your comment.

Summary

Sub-issue of https://github.com/learningequality/studio/issues/5060.

Migrate Failed to delete account alert in Settings > Account from Vuetify to Kolibri Design System.

shared/views/Alert that is built with several Vuetify components is used to show this alert. To remove this dependency from DeleteAccountForm, use KModal instead of Alert.

How to get there

  • Login as [email protected]
  • Go to Settings > Account
  • In code, temporarily modify deletionFailed to display the alert

Guidance

Out of scope

  • Do not refactor any other areas of the codebase
  • Do not modify Alert

Expected UI/UX changes

  • Minor visual differences naturally stemming from the use of KDS

Acceptance criteria

General

  • [ ] The specification above is followed.
  • [ ] Except for "Expected UI/UX changes," there are no functional or visual differences in user experience.
  • [ ] All user interactions are manually tested with no regressions.
  • [ ] Pull request includes screenshots.

a11y and i18n

See the project's "Guidance" for useful references.

  • [ ] Implementation meets a11y standards
  • [ ] All components are LTR and RTL compliant
  • [ ] All user-facing strings are translated properly
  • [ ] The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)
  • [ ] Mobile experience is reasonable

Unit tests

  • [ ] If there is a unit test suite already, it is meaningfully updated (even if tests don't fail)
  • [ ] If there is no unit test suite, a new one is created

MisRob avatar May 19 '25 10:05 MisRob

Hi @MisRob, can I work on this issue?

Abhishek-Punhani avatar May 30 '25 07:05 Abhishek-Punhani

Hi @Abhishek-Punhani, I'm glad to hear from you and hope all is well.

Yes, we're happy to have you work on this. Please have a look at the project this issue is part of to understand context.

MisRob avatar May 30 '25 10:05 MisRob

@MisRob I have raised a PR , please review it at your convinience . Thanks!

Abhishek-Punhani avatar May 30 '25 12:05 Abhishek-Punhani

Thanks @Abhishek-Punhani, for this project I should be able to review faster than in the previous weeks so you will hear from me soon - probably Monday, Tuesday

MisRob avatar May 30 '25 13:05 MisRob

Closed by https://github.com/learningequality/studio/pull/5079

MisRob avatar Jun 04 '25 04:06 MisRob