studio icon indicating copy to clipboard operation
studio copied to clipboard

Ensure the trash view fetches nodes in the same order as displayed

Open bjester opened this issue 1 year ago • 2 comments

Observed behavior

  • We had a bug with the trash pagination where loading more appended the data to the top of the view https://github.com/learningequality/studio/issues/4837
  • For a quick fix, we removed the reversed ordering in the frontend https://github.com/learningequality/studio/pull/4845
  • The fetching of nodes is far removed from the modal itself, meaning having that view passthrough the desired ordering involves several layers of code, which wasn't ideal for a quick patch fix

Expected behavior

  • We do want the trash to show the most recent first
  • When fetching the nodes initially and subsequently when loading more, we should use the same ordering as intended for display, so the user experience feels consistent with the UI

Steps to reproduce the issue

Please see the original bug and the quick in the PR

bjester avatar Dec 03 '24 22:12 bjester

A new bug with the trash view was found https://github.com/learningequality/studio/issues/4851.

Perhaps for simplicity's sake, we should just automate the pagination to eliminate the odd user experiences with loading more. Primarily, I'm concerned that trying to fix those odd experiences will require more effort to implement than they're worth

bjester avatar Dec 04 '24 16:12 bjester

@bjester can you assign me this issue 😃

GarvitSinghal47 avatar Mar 18 '25 13:03 GarvitSinghal47

Fixed in #4967

rtibbles avatar Jun 17 '25 02:06 rtibbles