studio icon indicating copy to clipboard operation
studio copied to clipboard

Migrate Studio dropshadows to KDS

Open MisRob opened this issue 1 year ago • 2 comments

Summary

As part of migrating Studio to KDS, we will need to move away from Vuetify's elevation system to using KDS dropshadows. We will also need to remove custom box-shadows.

Guidance

References

Relevant places discovered so far:

  • https://github.com/search?q=repo%3Alearningequality%2Fstudio+box-shadow&type=code
  • https://github.com/learningequality/studio/blob/e415aff29f10d6a26041e0c99b8184985ac0a0a6/contentcuration/contentcuration/frontend/shared/styles/vuetify.scss#L2121-L2219
  • https://github.com/learningequality/studio/blob/e415aff29f10d6a26041e0c99b8184985ac0a0a6/contentcuration/contentcuration/frontend/shared/views/MarkdownEditor/MarkdownEditor/ImagesMenu/ImagesMenu.vue#L6

Needs decision

  • Will we want to update styles/vuetify.scss or just remove elevations from there completely?
  • How do we best scope these updates: sub-tasks, all at once?
  • At what point this would be suitable to do?
    • @MisRob: Since Studio still uses many Vuetify components that are presumably consistent with the elevation styles, I wonder if this would be one of the last tasks to do in the migration process?

MisRob avatar Nov 13 '24 16:11 MisRob

hey @MisRob, can I work on this issue since I also worked with dropshadows in both kolibri and kolibri-design-system

lokesh-sagi125 avatar Feb 02 '25 21:02 lokesh-sagi125

Hi @lokesh-sagi125 - thanks for your interest! Since this is still labeled as "Needs Decisions" it's not quite ready for assignment yet, but once it is, we'll tag it as help wanted and check to see if you're still interested in working on it!

marcellamaki avatar Feb 03 '25 22:02 marcellamaki