studio
studio copied to clipboard
UI Modal for Flagging ContentNodes
Summary
This PR --
- Adds a
Flag content
option to the contentnode three-dot menu. - Introduces a UI Modal upon click of
Flag content
option that shows checkboxes for reporting a node.
TO DO --
- [ ] Implement
handleSubmit()
method. Can only be done after https://github.com/learningequality/studio/pull/4373 is merged.
Manual verification steps performed
Manual verification mainly revolves around checking when and when not Flag content
option is shown. So let's divide it into two parts -- first for normal users and second for admins.
For normal non-admin users
Flag option should show only when these three conditions meet -- AI feature flag is enabled for user, node is not of topic kind and user does not have edit permissions on the channel, that is, all public channels that user have not created themselves.
So to test the above conditions follow the below steps --
- Log in as admin.
- Enable ai feature flag for a normal user e.g. for [email protected]
- Create a channel with two nodes -- a topic node and a video file node.
- Publish that channel and make that channel public.
- Logout & login as user now.
- Go to content library and open that public channel.
- Click on three-dot menu of topic contentnode,
Flag content
option should not be there. - Click on three-dot menu of video contentnode,
Flag content
option should be there. - Done!
For admin users
Flag option should show in ALL channels when -- AI feature flag is enabled for admin and node is not of topic kind.
So to test the above conditions follow the below steps --
- Log in as a normal user.
- Create a channel with two nodes -- a topic node and a video file node.
- Log out and login as admin.
- Enable ai feature flag for admin.
- Go to administration -> channels.
- Visit that unpublished channel.
- Click on three-dot menu of topic contentnode,
Flag content
option should not be there. - Click on three-dot menu of video contentnode,
Flag content
option should be there. - Done!
Screenshots (if applicable)
1. Flag content
option UI
2. Flag modal UI
Reviewer guidance
Performing manual verification steps should make us confident about the changes.
References
Closes https://github.com/learningequality/studio/issues/4367. Closes https://github.com/learningequality/studio/issues/4365.
Contributor's Checklist
PR process:
- [ ] If this is an important user-facing change, PR or related issue the
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time - [ ] If this includes an internal dependency change, a link to the diff is provided
- [ ] The
docs
label has been added if this introduces a change that needs to be updated in the user docs? - [ ] If any Python requirements have changed, the updated
requirements.txt
files also included in this PR - [ ] Opportunities for using Google Analytics here are noted
- [ ] Migrations are safe for a large db
Studio-specifc:
- [ ] All user-facing strings are translated properly
- [ ] The
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text) - [ ] All UI components are LTR and RTL compliant
- [ ] Views are organized into
pages
,components
, andlayouts
directories as described in the docs - [ ] Users' storage used is recalculated properly on any changes to main tree files
- [ ] If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.
Testing:
- [x] Code is clean and well-commented
- [x] Contributor has fully tested the PR manually
- [x] If there are any front-end changes, before/after screenshots are included
- [ ] Critical user journeys are covered by Gherkin stories
- [ ] Any new interactions have been added to the QA Sheet
- [ ] Critical and brittle code paths are covered by unit tests
Reviewer's Checklist
This section is for reviewers to fill out.
- [ ] Automated test coverage is satisfactory
- [ ] PR is fully functional
- [ ] PR has been tested for accessibility regressions
- [ ] External dependency files were updated if necessary (
yarn
andpip
) - [ ] Documentation is updated
- [ ] Contributor is in AUTHORS.md