studio icon indicating copy to clipboard operation
studio copied to clipboard

Exercise editor text fields font-size rather small

Open bjester opened this issue 2 years ago • 13 comments

Observed behavior

The font size in the exercise editor fields is rather small, at 13px.

Expected behavior

The currently rendered size in Kolibri is 14px, which is also rather small, but the other text fields in Studio have a font-size that is much larger (e.g. 16px) which ideally they should match.

User-facing consequences

Readability concerns and also a mismatch with Kolibri's rendered size

bjester avatar Nov 03 '23 16:11 bjester

Can you assign me this issue please @bjester

ProgrammingPirates avatar Feb 10 '24 16:02 ProgrammingPirates

@ProgrammingPirates Thank you for your interest. I've assigned you this issue. I think a good improvement would be raising the size to at least 14px but I'm going to ask our design team for their thoughts.

bjester avatar Feb 12 '24 21:02 bjester

@ProgrammingPirates Lets raise it to 16px. Thank you!

bjester avatar Feb 12 '24 21:02 bjester

Hello @ProgrammingPirates. is this issue work in progress or should we unassign?

MisRob avatar Mar 15 '24 14:03 MisRob

I have working on this issue

On Fri, Mar 15, 2024, 8:07 PM Michaela Robosova @.***> wrote:

Hello @ProgrammingPirates https://github.com/ProgrammingPirates. is this issue work in progress or should we unassign?

— Reply to this email directly, view it on GitHub https://github.com/learningequality/studio/issues/4326#issuecomment-1999805773, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZGWFQCL4QPJNK7I3LHIBDYYMBTRAVCNFSM6AAAAAA64WHYMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZHAYDKNZXGM . You are receiving this because you were mentioned.Message ID: @.***>

ProgrammingPirates avatar Mar 15 '24 14:03 ProgrammingPirates

Okay, I will leave the assignment then, thank you!

MisRob avatar Mar 15 '24 14:03 MisRob

Can I work on this issue @MisRob?

galovdev avatar Mar 21 '24 03:03 galovdev

Hi @ProgrammingPirates, are there any updates on this? If @ProgrammingPirates is no longer working on this, we can assign it to you, @galovdev!

ozer550 avatar Mar 21 '24 11:03 ozer550

Please give me 2 day time only

On Thu, Mar 21, 2024, 4:35 PM Prathamesh Desai @.***> wrote:

Hi @ProgrammingPirates https://github.com/ProgrammingPirates, are there any updates on this? If @ProgrammingPirates https://github.com/ProgrammingPirates is no longer working on this, we can assign it to you, @galovdev https://github.com/galovdev!

— Reply to this email directly, view it on GitHub https://github.com/learningequality/studio/issues/4326#issuecomment-2011953762, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZGWFS2MY5PJ62PJLMDTS3YZK5ITAVCNFSM6AAAAAA64WHYMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRHE2TGNZWGI . You are receiving this because you were mentioned.Message ID: @.***>

ProgrammingPirates avatar Mar 21 '24 11:03 ProgrammingPirates

Hi @ProgrammingPirates, it seems there's no work going on so I will unassign you for now. If you'd like to return to this, let us know.

MisRob avatar May 11 '24 08:05 MisRob

Hi @bjester , 👋

I would love to take on this issue and improve the font size consistency in the exercise editor. Ensuring readability and uniformity across Kolibri Studio will enhance the user experience.

Proposed Solution: ✅ Increase Font Size: Adjust the font size in the exercise editor fields from 13px to 16px to match other text fields in Studio.
✅ Ensure Consistency with Kolibri:** The rendered size in Kolibri is 14px, so I will ensure a seamless experience between Studio and Kolibri.
✅ CSS Adjustments: Modify relevant styles in the appropriate stylesheets to reflect the correct font size across all input fields in the exercise editor.
✅ Testing & Review: Verify changes across different browsers and ensure no unintended UI issues arise.

Next Steps: If approved, I will:
1️⃣ Clone the repo and set up the local environment.
2️⃣ Identify where the font size is being set.
3️⃣ Apply changes and test them across different pages.
4️⃣ Open a PR for review.

Let me know if there are any specific guidelines I should follow! Excited to contribute. 😊

Thanks,
@yashodipmore

yashodipmore avatar Mar 23 '25 17:03 yashodipmore

Hi @yashodipmore, I will assign you, thanks!

bjester avatar Mar 24 '25 17:03 bjester

Automatically unassigning @yashodipmore due to no comments here, or updates on the associated pull request for 1 month. @yashodipmore, if you're still interested in this issue or already have work in progress, please message us here, and we'll assign you again. Thank you!

Should be safely closed with the new editor implementation now.

https://github.com/learningequality/studio/blob/37be7a5f40234871037869b2bfaf6347c4d3d958/contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/TipTapEditor.vue#L401-L405

habibayman avatar Sep 25 '25 01:09 habibayman

Confirmed that p elements now have a 16px font-size to match the rest of Studio.

rtibbles avatar Sep 25 '25 01:09 rtibbles