studio icon indicating copy to clipboard operation
studio copied to clipboard

Lengthy resource title collides with channel name in import modal

Open bjester opened this issue 2 years ago • 31 comments

Observed behavior

Reported by @thanksameeelian: When reviewing selections of items to import into a channel, long resource names run up against the names of the channels that contain them Screen Shot 2023-05-11 at 12 46 29 PM

Expected behavior

No text collisions

bjester avatar May 22 '23 19:05 bjester

We could move TextTruncatorCss from Kolibri to KDS and then use it in Studio too for cases like this

MisRob avatar Jun 06 '23 12:06 MisRob

@MisRob Would you write up something in KDS for this then?

bjester avatar Jun 06 '23 14:06 bjester

@bjester https://github.com/learningequality/kolibri-design-system/issues/450

MisRob avatar Sep 22 '23 15:09 MisRob

I am interested in contributing in this issue. @bjester and @MisRob can you please assign me this issue?

chetanbarakki avatar Oct 26 '24 13:10 chetanbarakki

Hey @ChetanCoder24! Thank you for your interest in contributing to this issue. I will assign this to you! If you have any question, please let us know šŸ¤—

AlexVelezLl avatar Oct 28 '24 14:10 AlexVelezLl

Hi @ChetanCoder24, are you still planning to work on this?

MisRob avatar Dec 02 '24 19:12 MisRob

hi @AlexVelezLl and @MisRob, i am first time contributor and i am interested to contribute in this issue. can you please assign me this issue?

Yashkrit-Singh avatar Dec 06 '24 11:12 Yashkrit-Singh

Hi @Yashkrit-Singh, welcome! Thanks for volunteering, I will assign you.

MisRob avatar Dec 09 '24 04:12 MisRob

Thanks! @MisRob

Yashkrit-Singh avatar Dec 09 '24 14:12 Yashkrit-Singh

hi @MisRob, i am confused why my local development server is not running. pyenv is creating difficulty in installation and on running the frontend server alone pyenv is not letting it run locally.

sorry for asking such silly question, its truely my first time doing so and i wanna contribute šŸ˜…šŸ˜…

Yashkrit-Singh avatar Dec 09 '24 19:12 Yashkrit-Singh

Hi @Yashkrit-Singh, it's alright to ask this.

I'd ask you to follow closely https://github.com/learningequality/studio/blob/unstable/docs/local_dev_docker.md step by step and keep all the screenshots/logs/recording of the whole process. If you hit an error, it'd be best to open a new post in the Studio Discussions and post as most information you can, and also mention there what's your operating system.

MisRob avatar Dec 12 '24 05:12 MisRob

@MisRob local server started working Image

Thanks for the cooperation

Yashkrit-Singh avatar Dec 14 '24 08:12 Yashkrit-Singh

hi @MisRob , Image i have added some documents/resources in the Published Channel but on importing resources from other channel, its showing the resource not available Image

Do i need to publish this to kolibri ?

Yashkrit-Singh avatar Dec 14 '24 18:12 Yashkrit-Singh

Hi @Yashkrit-Singh,

to be able to access the "Review selections" page when importing to a channel:

  • Login as [email protected]
  • Navigate to "Imported channel"
  • Click "Add" > "Import from channels"
  • Select some non-topic resources from "Published channel"
  • Click "Review"

MisRob avatar Dec 17 '24 16:12 MisRob

@Yashkrit-Singh and to get a longer text than in the original samples of the "Published channel", you can just override markup in the browser console.

MisRob avatar Dec 17 '24 17:12 MisRob

@Yashkrit-Singh Also I wanted to mention that Learning Equality will be closed from December 23 to January 5.

MisRob avatar Dec 17 '24 17:12 MisRob

@MisRob I noticed that this issue is currently assigned to @Yashkrit-Singh . If he is currently not working on this issue, would it be possible to assign this issue to me? I’d be happy to work on it.

shruti862 avatar Jan 08 '25 19:01 shruti862

Hey @Yashkrit-Singh! Are you still interested in working on this issue?

AlexVelezLl avatar Jan 10 '25 13:01 AlexVelezLl

Unassigning due to inactivity. If you are still interested in workingon this issue @shruti862, let me know :).

AlexVelezLl avatar Jan 14 '25 12:01 AlexVelezLl

Hey @AlexVelezLl ,Yes I am interested to work on this issue, please assign me

shruti862 avatar Jan 14 '25 13:01 shruti862

Thanks @shruti862! If you have any questions, please let us know :).

AlexVelezLl avatar Jan 14 '25 13:01 AlexVelezLl

Hey @bjester @AlexVelezLl I have raised a PR could you please review it whenever you gets time and let me know if any changes needed :)

shruti862 avatar Jan 15 '25 14:01 shruti862

Hey @MisRob ,@bjester, @AlexVelezLl While resolving this issue I noticed that KTextTruncator Component in KDS does not have usage section so I wanted to know, is there already a Issue open regarding this ??

Image

shruti862 avatar Jan 15 '25 14:01 shruti862

Hey @shruti862, thanks! We will review the PR soon. And no, there isnt an open issue for this yet, please feel free to open an issue for it if you are confortable with it :).

AlexVelezLl avatar Jan 17 '25 15:01 AlexVelezLl

Thanks @AlexVelezLl for informing :)

shruti862 avatar Jan 17 '25 17:01 shruti862

Hi @shruti862 are you still working on this issue if not then @AlexVelezLl can assign it to me :)

yashhash2 avatar Mar 10 '25 11:03 yashhash2

@yashhash2 , Yes I am working on this issue.

shruti862 avatar Mar 11 '25 07:03 shruti862

Hi @shruti862 , are you still planning to work on this issue? I can work on this issue if you are busy with other engagements. Please let me know

Abhishek-Punhani avatar Apr 22 '25 10:04 Abhishek-Punhani

Hi @Abhishek-Punhani , Yes I am still working on this issue.

shruti862 avatar Apr 22 '25 11:04 shruti862

Sure, @shruti862 , I was just checking in.

Abhishek-Punhani avatar Apr 22 '25 14:04 Abhishek-Punhani